Skip to content

fix(transloco): fixed error when inline loader for lang is not provided#760

Open
adpawlik wants to merge 1 commit intojsverse:masterfrom
adpawlik:bugfix/error-missed-inline-loader-for-path
Open

fix(transloco): fixed error when inline loader for lang is not provided#760
adpawlik wants to merge 1 commit intojsverse:masterfrom
adpawlik:bugfix/error-missed-inline-loader-for-path

Conversation

@adpawlik
Copy link

@adpawlik adpawlik commented Apr 23, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If you use an inline loader and specify a language that is not included in the map, an error occurs.
e.g.

export const loader = ['en', 'es'].reduce((acc, lang) => {
    acc[lang] = () => import(`../i18n/${lang}.json`);
    return acc;
}, {});

export const FEATURE_ROUTES: Route = {
  path: 'feature',
  loadComponent: () => import('./feature.component').then(FeatureComponent => FeatureComponent),
  providers: [
    provideTranslocoScope({
      scope: 'scopeName',
      loader
    })
  ]
};

Issue Number: N/A

What is the new behavior?

The lack of a language in the given map does not cause the application to crash, it only logs an error in the case of the development version and loads a fallback language

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@shaharkazaz
Copy link
Collaborator

shaharkazaz commented Apr 24, 2024

@adpawlik I'm not sure that crashing the app is the desired behavior here, why did you feel you needed to make this change?

@adpawlik
Copy link
Author

adpawlik commented Apr 24, 2024

@shaharkazaz Because it is not good to throw an error at this point, because the "resolveLoader" function is used in transloco.service.ts and such an error will not be caught by catchError in rxjs, and therefore the fallback language will not be loaded.

Currently, all inline loaders must have map entries for each available language.

e.g.

//componentA 
export const loader = ['en', 'es'].reduce((acc, lang) => {
    acc[lang] = () => import(`../i18n/${lang}.json`);
    return acc;
}, {});

//componentB 
export const loader = ['en', 'es', 'de'].reduce((acc, lang) => {
    acc[lang] = () => import(`../i18n/${lang}.json`);
    return acc;
}, {});

If you try to load the 'de' language for componentA, it fails.

@shaharkazaz shaharkazaz force-pushed the master branch 5 times, most recently from c068fa2 to d2ade9f Compare January 6, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wszydlak wszydlak wszydlak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adpawlik @shaharkazaz @wszydlak